diff --git a/src/main/java/ysoserial/secmgr/ExecCheckingSecurityManager.java b/src/main/java/ysoserial/secmgr/ExecCheckingSecurityManager.java index 310179c..940afb0 100644 --- a/src/main/java/ysoserial/secmgr/ExecCheckingSecurityManager.java +++ b/src/main/java/ysoserial/secmgr/ExecCheckingSecurityManager.java @@ -6,6 +6,7 @@ import java.util.LinkedList; import java.util.List; import java.util.concurrent.Callable; +// TODO per-thread secmgr public class ExecCheckingSecurityManager extends SecurityManager { public ExecCheckingSecurityManager() { this(true); @@ -41,7 +42,6 @@ public class ExecCheckingSecurityManager extends SecurityManager { } }; - @SuppressWarnings("serial") public static class ExecException extends RuntimeException { private final String threadName = Thread.currentThread().getName(); diff --git a/src/test/java/ysoserial/payloads/CommandExecTest.java b/src/test/java/ysoserial/payloads/CommandExecTest.java index 22a952c..b0dc051 100644 --- a/src/test/java/ysoserial/payloads/CommandExecTest.java +++ b/src/test/java/ysoserial/payloads/CommandExecTest.java @@ -16,7 +16,6 @@ public class CommandExecTest implements CustomTest { @Override public void run(Callable payload) throws Exception { Assert.assertFalse("test file should not exist", testFile.exists()); - Exception err; try { payload.call(); } catch (Exception e) { diff --git a/src/test/java/ysoserial/payloads/PayloadsTest.java b/src/test/java/ysoserial/payloads/PayloadsTest.java index 904eb83..9a29e8e 100644 --- a/src/test/java/ysoserial/payloads/PayloadsTest.java +++ b/src/test/java/ysoserial/payloads/PayloadsTest.java @@ -107,8 +107,8 @@ public class PayloadsTest { customDeserializer = ((CustomDeserializer)testHarness).getCustomDeserializer(); } - ExecCheckingSecurityManager sm = new ExecCheckingSecurityManager(); - final byte[] serialized = sm.callWrapped(makeSerializeCallable(payloadClass, payloadCommand)); + // TODO per-thread secmgr to enforce no detonation during deserialization + final byte[] serialized = makeSerializeCallable(payloadClass, payloadCommand).call(); Callable callable = makeDeserializeCallable(t, addlClassesForClassLoader, deps, serialized, customDeserializer); if ( testHarness instanceof WrappedTest ) { callable = ( (WrappedTest) testHarness ).createCallable(callable);